Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] small fixes in hostmetrics, no need of using mocks #36476

Merged

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu force-pushed the fix_hostmetricsreceiver branch from 149ad61 to 59bb2fc Compare November 20, 2024 20:41
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatsheep9146 fatsheep9146 added the ready to merge Code review completed; ready to merge by maintainers label Nov 23, 2024
@andrzej-stencel andrzej-stencel merged commit 5dcd37e into open-telemetry:main Nov 25, 2024
168 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 25, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/hostmetrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants